php-enqueue / enqueue-dev

Message Queue, Job Queue, Broadcasting, WebSockets packages for PHP, Symfony, Laravel, Magento. DEVELOPMENT REPOSITORY - provided by Forma-Pro
https://enqueue.forma-pro.com/
MIT License
2.17k stars 429 forks source link

Add `void` return type in DoctrineSchemaCompilerPass and MessageQueueCollector #1312

Closed ruudk closed 4 months ago

ruudk commented 1 year ago

Fixes these deprecations on Symfony 6.3:

Method "Symfony\Component\DependencyInjection\Compiler\CompilerPassInterface::process()" might add "void" as a native return type declaration in the future. Do the same in implementation "Enqueue\Doctrine\DoctrineSchemaCompilerPass" now to avoid errors or add an explicit @return annotation to suppress this message.
Method "Symfony\Component\HttpKernel\DataCollector\DataCollectorInterface::collect()" might add "void" as a native return type declaration in the future. Do the same in implementation "Enqueue\Bundle\Profiler\MessageQueueCollector" now to avoid errors or add an explicit @return annotation to suppress this message.
ruudk commented 1 year ago

@makasim This one is ready for review.

ruudk commented 1 year ago

@makasim I fixed the CS error. If you approve, it's going to be green. Except for 1 failing test that is out of my control. Could you please merge this? Thanks.

makasim commented 1 year ago

Unfortunately, I cannot merge the red build, If it makes to the main it will stay there for a long time, making the whole idea of testing and CI useless.

ruudk commented 1 year ago

Main is already red: https://github.com/php-enqueue/enqueue-dev/commits/master

The error on this PR is the same, so that's what I mean.

Obviously this PR doesn't create new errors 😅

ruudk commented 1 year ago

I give up. The errors in this PR are unrelated to my changes.

ruudk commented 10 months ago

This fails because this project uses PHPStan 0.12, which is outdated. It should be updated to PHPStan ^1.8.