Open snapshotpl opened 8 months ago
@VincentLanglet I waiting for this future. So, I have fix your comments in a PR to the code of snapshotpl. Only, I am new here so I don't know if I do it right: https://github.com/snapshotpl/enqueue-dev/pull/1
And If snapshot react not quick. Is it then better to make a new PR?
And If snapshot react not quick. Is it then better to make a new PR?
It seems better indeed because there is still a lot of work. Look at https://github.com/php-enqueue/enqueue-dev/pull/1330, lot of build are failing...
If you open a PR, unfortunately I think the CI will need approval to run. (I don't have this issue cause I already contributed). If you want to can work on the error and I can cherry-pick your commit if you need the CI to run.
And If snapshot react not quick. Is it then better to make a new PR?
It seems better indeed because there is still a lot of work. Look at #1330, lot of build are failing...
If you open a PR, unfortunately I think the CI will need approval to run. (I don't have this issue cause I already contributed). If you want to can work on the error and I can cherry-pick your commit if you need the CI to run.
I have make an own https://github.com/php-enqueue/enqueue-dev/pull/1331 Please, give feedback :)
any update on this?
@snapshotpl are you make the changes to this branch with the feedback? Or what is your planning?