php-enqueue / enqueue-dev

Message Queue, Job Queue, Broadcasting, WebSockets packages for PHP, Symfony, Laravel, Magento. DEVELOPMENT REPOSITORY - provided by Forma-Pro
https://enqueue.forma-pro.com/
MIT License
2.17k stars 429 forks source link

Bump symfony from 6.0 to 6.4 and add support for 7.0 #1326

Open snapshotpl opened 8 months ago

TechComBiz commented 7 months ago

@snapshotpl are you make the changes to this branch with the feedback? Or what is your planning?

TechComBiz commented 7 months ago

@VincentLanglet I waiting for this future. So, I have fix your comments in a PR to the code of snapshotpl. Only, I am new here so I don't know if I do it right: https://github.com/snapshotpl/enqueue-dev/pull/1

And If snapshot react not quick. Is it then better to make a new PR?

VincentLanglet commented 7 months ago

And If snapshot react not quick. Is it then better to make a new PR?

It seems better indeed because there is still a lot of work. Look at https://github.com/php-enqueue/enqueue-dev/pull/1330, lot of build are failing...

If you open a PR, unfortunately I think the CI will need approval to run. (I don't have this issue cause I already contributed). If you want to can work on the error and I can cherry-pick your commit if you need the CI to run.

TechComBiz commented 7 months ago

And If snapshot react not quick. Is it then better to make a new PR?

It seems better indeed because there is still a lot of work. Look at #1330, lot of build are failing...

If you open a PR, unfortunately I think the CI will need approval to run. (I don't have this issue cause I already contributed). If you want to can work on the error and I can cherry-pick your commit if you need the CI to run.

I have make an own https://github.com/php-enqueue/enqueue-dev/pull/1331 Please, give feedback :)

AlexOstrovsky commented 7 months ago

any update on this?