search

php-enqueue / enqueue-dev

Message Queue, Job Queue, Broadcasting, WebSockets packages for PHP, Symfony, Laravel, Magento. DEVELOPMENT REPOSITORY - provided by Forma-Pro
https://enqueue.forma-pro.com/
MIT License
2.17k stars 429 forks source link

Bugfix in `RdKafkaProducer:flush()` method #1347

Open alexbusu-motork opened 4 months ago

alexbusu-motork commented 4 months ago

Avoid TypeError in RdKafkaProducer::flush()

alexbusu-motork commented 4 months ago

It seems there is an issue with localstack deployment, because after the services are up, one of them (the one on port 4576) shuts down. All of the http requests to service healtcheck curl -i http://localhost:4576/_localstack/health will return 404 :shrug: What I've tried is to change the localstack image version, by downgrading and upgrading the patch, minor and major versions, but still no luck in having it working. I notice that this issue happens in other PRs as well. @makasim @Steveb-p please help with this issue.

makasim commented 4 months ago

@makasim @Steveb-p please help with this issue.

I can review PR and merge green one. Release a new version. That's it. So, don't expect me to fix failing CI.

alexbusu-motork commented 4 months ago

@makasim ok, please let me know - since this is a failing component of testing stage (not related to the code quality/functionality itself) - who could help me with this issue? I mean, who is maintaining the functional tests environment, so we can check together?

makasim commented 4 months ago

Contributors, like you.

alexbusu-motork commented 4 months ago

@makasim please run the workflow. I've brought some changes.

alexbusu commented 2 months ago

@makasim please run the workflow again.

alexbusu commented 2 months ago

@makasim please run the workflow.

alexbusu commented 2 months ago

Now the only failing test is Enqueue\SnsQs\Tests\Spec\SnsQsSendToTopicAndReceiveNoWaitFromQueueTest::test():

Failed asserting that null is an instance of interface "Interop\Queue\Message".

https://github.com/php-enqueue/enqueue-dev/actions/runs/9580921964/job/26416695363?pr=1347#step:10:266

@makasim @Steveb-p it's not clear to me why this fails here; it is not failing when I run for the same environment on my local machine. What would you suggest, what should I try?