search

php-enqueue / enqueue-dev

Message Queue, Job Queue, Broadcasting, WebSockets packages for PHP, Symfony, Laravel, Magento. DEVELOPMENT REPOSITORY - provided by Forma-Pro
https://enqueue.forma-pro.com/
MIT License
2.17k stars 429 forks source link

feat(GPS): allow send attributes in Google PubSub message. #1349

Closed p-pichet closed 1 week ago

p-pichet commented 3 months ago

Allow to send PubSub attributes

p-pichet commented 2 months ago

@makasim Can someone look at this PR please ?

p-pichet commented 2 months ago

Hello @dgafka. Can you review this PR or tell me who can ?

dgafka commented 2 months ago

Hello @p-pichet I am not maintainer of this package, @makasim is ;)

p-pichet commented 2 months ago

as i saw you approve some requests and i don't have any responses, i ask you but i understand.

p-pichet commented 1 month ago

@makasim

makasim commented 1 month ago

ci pipeline does not trigger for this PR. I dont know why. I cannot merge PR without it being tested on CI succesfully.

p-pichet commented 1 month ago

ci pipeline does not trigger for this PR. I dont know why. I cannot merge PR without it being tested on CI succesfully.

i see why the CI is not trigger. You are agree with the modification ?

p-pichet commented 1 month ago

I don't understand how to run CI.

p-pichet commented 1 month ago

Hi @makasim, can you run CI actions, please?

makasim commented 1 month ago

I cannot, I would do it if it were possible

p-pichet commented 1 month ago

I hesitate if it was a trigger message. Do you know the condition to enable the CI ? Is it because my repository is not correctly setup ?

makasim commented 1 month ago

CI has to be triggered on any MR by default without any additional actions from any side. There is one exception where a maintainer has to approve CI but there is none.

makasim commented 1 month ago

Maybe try open a new PR from new branch, hope it helps

p-pichet commented 1 month ago

@makasim i push a fix, can you run the CI please.

p-pichet commented 1 month ago

@makasim i push a change, can you run the CI please.

p-pichet commented 1 month ago

@makasim i push a change, can you run the CI please.

p-pichet commented 3 weeks ago

@makasim I push a change, can you run the CI please. For the version 8.x of PHP, we got issue on the SQS, but I don't touch it. Who can have a look at it ?

p-pichet commented 2 weeks ago

@makasim We found that the 404 error come from an update of aws/aws-sdk-php. Who is in charge of the maintenance of external lib ?

p-pichet commented 2 weeks ago

@makasim I push a change, can you run the CI please.

p-pichet commented 2 weeks ago

@makasim it's seem the image use to run CI not found the docker compose command.

p-pichet commented 2 weeks ago

@makasim I push a change, can you run the CI please.

p-pichet commented 2 weeks ago

And for information docker-compose has been remove https://github.com/actions/runner-images/blob/main/images/ubuntu/Ubuntu2204-Readme.md

p-pichet commented 2 weeks ago

@makasim i push again please run the ci

p-pichet commented 2 weeks ago

@makasim can you run the CI please ?

Steveb-p commented 2 weeks ago

You can ping me instead :sweat_smile:

I've ran most of your requests recently :)

p-pichet commented 2 weeks ago

thanks @Steveb-p . Have you see my other messages ?

Steveb-p commented 2 weeks ago

thanks @Steveb-p . Have you see my other messages ?

Yeah, but I'm mostly in the same situation as you are. I was mostly involved in rdkafka itself when I was working on queues in my old job, and can't really help with those custom docker images :confounded:

p-pichet commented 2 weeks ago

@Steveb-p can you run the CI please

p-pichet commented 1 week ago

@Steveb-p i try something can you run the CI ?

p-pichet commented 1 week ago

@Steveb-p and @makasim, the CI fail on the SQS and SNS. We don't have strong knowledge to understand what happen. do you have a name to someone can help use ? Maybe @ASKozienko as you work on the failing test.

p-pichet commented 1 week ago

@Steveb-p can you run the CI please ?

p-pichet commented 1 week ago

Thanks @Steveb-p The CI is green. Who can merge it ?

Steveb-p commented 1 week ago

Thanks @Steveb-p The CI is green. Who can merge it ?

Let me review the code after work, just in case.

p-pichet commented 1 week ago

@Steveb-p can you run the CI and take a new look on the code please ?

p-pichet commented 1 week ago

@Steveb-p, I push the missing code style. Can you run the CI please ? And as you validate the PR, what I need to do for its merge ?

p-pichet commented 1 week ago

Forgot the part to get the attributes on receive a message.

makasim commented 1 week ago

Few comments from me, Almost there.

p-pichet commented 1 week ago

@Steveb-p and @makasim i push a fix for your comment and a code to get attributes for received. Can you run the CI and validate the PR please ?

makasim commented 1 week ago

@p-pichet big thank you for your tireless work. Enqueue's CI is green and it not only provides the feature you need but unblocks a lot of other stuck MRs.

Kudos to you, much appreciated!

p-pichet commented 1 week ago

@p-pichet big thank you for your tireless work. Enqueue's CI is green and it not only provides the feature you need but unblocks a lot of other stuck MRs.

Kudos to you, much appreciated!

Thanks a lot. When do you think the release will be created ?

makasim commented 1 week ago

released https://github.com/php-enqueue/enqueue-dev/blob/master/CHANGELOG.md#01021-2024-08-12