Closed p-pichet closed 1 week ago
@makasim Can someone look at this PR please ?
Hello @dgafka. Can you review this PR or tell me who can ?
Hello @p-pichet I am not maintainer of this package, @makasim is ;)
as i saw you approve some requests and i don't have any responses, i ask you but i understand.
@makasim
ci pipeline does not trigger for this PR. I dont know why. I cannot merge PR without it being tested on CI succesfully.
ci pipeline does not trigger for this PR. I dont know why. I cannot merge PR without it being tested on CI succesfully.
i see why the CI is not trigger. You are agree with the modification ?
I don't understand how to run CI.
Hi @makasim, can you run CI actions, please?
I cannot, I would do it if it were possible
I hesitate if it was a trigger message. Do you know the condition to enable the CI ? Is it because my repository is not correctly setup ?
CI has to be triggered on any MR by default without any additional actions from any side. There is one exception where a maintainer has to approve CI but there is none.
Maybe try open a new PR from new branch, hope it helps
@makasim i push a fix, can you run the CI please.
@makasim i push a change, can you run the CI please.
@makasim i push a change, can you run the CI please.
@makasim I push a change, can you run the CI please. For the version 8.x of PHP, we got issue on the SQS, but I don't touch it. Who can have a look at it ?
@makasim We found that the 404 error come from an update of aws/aws-sdk-php. Who is in charge of the maintenance of external lib ?
@makasim I push a change, can you run the CI please.
@makasim it's seem the image use to run CI not found the docker compose command.
@makasim I push a change, can you run the CI please.
And for information docker-compose has been remove https://github.com/actions/runner-images/blob/main/images/ubuntu/Ubuntu2204-Readme.md
@makasim i push again please run the ci
@makasim can you run the CI please ?
You can ping me instead :sweat_smile:
I've ran most of your requests recently :)
thanks @Steveb-p . Have you see my other messages ?
thanks @Steveb-p . Have you see my other messages ?
Yeah, but I'm mostly in the same situation as you are. I was mostly involved in rdkafka itself when I was working on queues in my old job, and can't really help with those custom docker images :confounded:
@Steveb-p can you run the CI please
@Steveb-p i try something can you run the CI ?
@Steveb-p and @makasim, the CI fail on the SQS and SNS. We don't have strong knowledge to understand what happen. do you have a name to someone can help use ? Maybe @ASKozienko as you work on the failing test.
@Steveb-p can you run the CI please ?
Thanks @Steveb-p The CI is green. Who can merge it ?
Thanks @Steveb-p The CI is green. Who can merge it ?
Let me review the code after work, just in case.
@Steveb-p can you run the CI and take a new look on the code please ?
@Steveb-p, I push the missing code style. Can you run the CI please ? And as you validate the PR, what I need to do for its merge ?
Forgot the part to get the attributes on receive a message.
Few comments from me, Almost there.
@Steveb-p and @makasim i push a fix for your comment and a code to get attributes for received. Can you run the CI and validate the PR please ?
@p-pichet big thank you for your tireless work. Enqueue's CI is green and it not only provides the feature you need but unblocks a lot of other stuck MRs.
Kudos to you, much appreciated!
@p-pichet big thank you for your tireless work. Enqueue's CI is green and it not only provides the feature you need but unblocks a lot of other stuck MRs.
Kudos to you, much appreciated!
Thanks a lot. When do you think the release will be created ?
Allow to send PubSub attributes