php-enqueue / enqueue-dev

Message Queue, Job Queue, Broadcasting, WebSockets packages for PHP, Symfony, Laravel, Magento. DEVELOPMENT REPOSITORY - provided by Forma-Pro
https://enqueue.forma-pro.com/
MIT License
2.18k stars 435 forks source link

feat(GPS): allow send attributes in Google PubSub message. #1352

Closed p-pichet closed 5 months ago

p-pichet commented 5 months ago

@makasim this one should be good.

Steveb-p commented 5 months ago

One of the tests requires an update, since you're changing behavior slightly.

All others are deprecations and warnings (these are awful, but it is how it is).

There was 1 failure:

1) Enqueue\Gps\Tests\GpsProducerTest::testShouldSendMessage
Expectation failed for method name is "publish" when invoked 1 time(s)
Parameter 0 for invocation Google\Cloud\PubSub\Topic::publish(Array (...), Array ()) does not match expected value.
Failed asserting that two arrays are identical.
--- Expected
+++ Actual
@@ @@
 Array &0 (
     'data' => '{"body":"","properties":[],"headers":[]}'
+    'attributes' => Array &1 ()
 )

/home/runner/work/enqueue-dev/enqueue-dev/pkg/gps/GpsProducer.php:42
/home/runner/work/enqueue-dev/enqueue-dev/pkg/gps/Tests/GpsProducerTest.php:55
phpvfscomposer:///home/runner/work/enqueue-dev/enqueue-dev/vendor/phpunit/phpunit/phpunit:60

--
p-pichet commented 5 months ago

thanks @Steveb-p The first PR decide to run the CI, i see to close this one