search

php-gettext / Gettext

PHP library to collect and manipulate gettext (.po, .mo, .php, .json, etc)
MIT License
687 stars 134 forks source link

Wrong CHANGELOG link in release notifications #243

Closed mlocati closed 4 years ago

mlocati commented 4 years ago

Just a minor issue, but still...

I just received the email notification about the new 8.4.2 version (you can watch "Releases only" in GitHub).

The link to the CHANGELOG file is wrong. Here's the HTML source of the email notification:

<p>See <a href="/php-gettext/Gettext/blob/v4.8.2/CHANGELOG.md">CHANGELOG</a></p>
oscarotero commented 4 years ago

Why do you think it's wrong? This link is generated automatically by github. I only write: 

See [CHANGELOG](CHANGELOG.md)

And github completes the url with the full path of the file in the tag.

mlocati commented 4 years ago

Why do you think it's wrong?

Because when I click on the link in the email I receive, the browser tries to navigate to /php-gettext/Gettext/blob/v4.8.2/CHANGELOG.md, which is missing the protocol and the host name.

And github completes the url with the full path of the file in the tag.

Yep, but the email notifications are wrong.

Here's the email I received: unzip it and open it with an EML viewer (like Thunderbird), or with a text editor to see the html.

oscarotero commented 4 years ago

I see. It looks more a Github issue (of course, I can type the full url, but it's a bit harder). Thanks for notify this.

oscarotero commented 4 years ago

I just released a new version with the full url of CHANGELOG. Feel free to reopen this if the link still failing.

mlocati commented 4 years ago

Thanks! I submitted this issue to the GitHub support team and they forwarded it to the tech team, so it's up to them now 😉