search

php-gettext / Gettext

PHP library to collect and manipulate gettext (.po, .mo, .php, .json, etc)
MIT License
687 stars 132 forks source link

Relative strings location path #259

Open Arzaroth opened 4 years ago

Arzaroth commented 4 years ago

Following the discussion in #256.

This addresses #208.

oscarotero commented 4 years ago

As commented in https://github.com/php-gettext/Gettext/pull/256#issuecomment-618588669 I think this change introduces unnecessary complexity to the Code Scanner, because the function scanString() allows to achieve this.

In fact, scanFile() uses scanString() internally: https://github.com/php-gettext/Gettext/blob/master/src/Scanner/Scanner.php#L41

So I'm going to pause this for now. Thanks, anyway!