Closed MichaelHoste closed 3 years ago
@oscarotero Do you think you could consider merging this small pull request in a new GetText 4.x release?
It seems that Blade component tags trigger an error when parsed by GetText (Unable to locate a class or view for component
). It's problematic for most Laravel 8 projects.
Or maybe it should work without this pull request and I'm doing something wrong?
(FYI The tests actually pass, but travis bugged on one of them)
Ok. (sorry I missed this pull request). Thanks!
Thank you very much for accepting this pull request, and also for this nice project! 😄
In a new Laravel 8 Jetstream project (created with
laravel new [name] --jet
), there is an exception when usingExtractors\Blade::fromFile($file, $translations);
It seems to be unable to locate the jet components, and therefore can't compile the Blade file to PHP.
i don't exactly know why it breaks, but a lot of things are recently updated regarding ComponentTag namespaces and it might be related to this error? (cf. https://github.com/laravel/framework/commit/7cc120ebfcccdecf02d5cdbec47f6eae63a8e5a9).
However, if I'm right, the Blade extractor doesn't need to compile ComponentTag to do its job correctly, so I created this pull request to always disable it, so that the 4.x branch could still work with Laravel 8/Jetstream.
i hope that makes sense!