php-gettext / Gettext

PHP library to collect and manipulate gettext (.po, .mo, .php, .json, etc)
MIT License
687 stars 132 forks source link

Replace `fopen`/`fread` with `file_get_contents` #276

Closed ideag closed 2 years ago

ideag commented 2 years ago

Fixes php-gettext/Gettext#257

ideag commented 2 years ago

@oscarotero If I understand correctly PHP codesniffer v3.4.2 is having trouble running on php 8.0?

oscarotero commented 2 years ago

Hi, thanks for this (and your sponsor!!). It looks good to me.

Yep, PHP codesniffer added support for PHP8 starting from 3.5. This error is from Scrutinizer that I'm going to remove it because it seems that it wasn't updated for long time.

ideag commented 2 years ago

Keep up the good work!