search

php-gettext / Twig-Scanner

Twig code scanner for gettext
GNU General Public License v3.0
4 stars 2 forks source link

Support installation on PHP 8.x #8

Closed tvdijen closed 2 years ago

drzraf commented 2 years ago

Do you mind changing .travis.yml too, to be sure this version is tested against in the CI?

tvdijen commented 2 years ago

Done!

drzraf commented 2 years ago

@oscarotero : What do you think? Isn't the testsuite expected to run for each PR?

tvdijen commented 2 years ago

I think you're still relying on travis-ci.org, which has been ceased for over a year..

oscarotero commented 2 years ago

Hi, thanks for this. Could travis.yml file be removed and use github actions? You can use the same file in Gettext main repository: https://github.com/php-gettext/Gettext/blob/master/.github/workflows/test.yaml

oscarotero commented 2 years ago

Thanks! Looks like the test workflow is failing.