search

php-http / HttplugBundle

Symfony Framework Integration for HTTPlug
http://httplug.io
MIT License
381 stars 50 forks source link

Only support supported Symfony versions #434

Closed ruudk closed 1 year ago

ruudk commented 1 year ago
Q A
Bug fix? no
New feature? no
BC breaks? no
Deprecations? no
Related tickets Documentation if this is a new feature, link to pull request in https://github.com/php-http/documentation that adds relevant documentation
License MIT

What's in this PR?

Only support Symfony versions that are not EOL.

https://symfony.com/releases

ostrolucky commented 1 year ago

What are we gaining by this change? I wouldn't drop older versions only until we can at least drop some BC layers.

ruudk commented 1 year ago

You mean I should remove BC compatibility for those older versions, if any, in order for this to be considered useful?

ostrolucky commented 1 year ago

If there are some BC layers for 4.4 then removing them and dropping 4.4 support could make sense. But I don't think we have any BC layers, that's why there isn't any benefit for just changing requirements. Having 4.4 there doesn't hold us back and raising requirement would be artificial, since project has no issues running under 4.4.

dbu commented 1 year ago

thanks for looking at this and the discussion. i agree with not dropping legacy only for the sake of dropping it. if there is anything hindering us, or if there is legacy support code e.g. in the DI system, then lets do it. but when there is additional code, its nice for people stuck on outdated symfony versions to still support them.