Closed soullivaneuh closed 11 months ago
I am not sure of what I did wrong to make some tests crying. May you give me a hint @dbu?
I found the reason. Apparently, it is because we are declaring the name
scalar value that make the configuration process being confused as name
is also used as a key attribute: https://github.com/pocivaneuh/HttplugBundle/blob/32caa9a2c95a4da393a0a91205ea904fe3c53960/src/DependencyInjection/Configuration.php#L640
I changed to key
instead: 32caa9a
All green! :+1: I also updated the documentation PR according to the configuration key name change.
ah right, i think that is for xml where you can't have a custom xml element and we use name as identifier attribute. in yaml its the my_auth:
part, and does not need an explicit name.
should we call the thing header_name
instead of key
? key is a bit generic and could be confusing in the context of security. it boils down to what header name to set in the request.
Oh that case, header_name
and header_value
to make things consistent?
yes, i like header_name and header_value. that makes it really clear and leaves no room for confusion (i hope :-) )
@dbu keys named was changed in 04414b2.
Squashed and rebased, ready for review! :+1:
What's in this PR?
Exposes configuration for the header authentication plugin.
Why?
Allows the direct usage of this plugin through the bundle configuration.
Example Usage
Checklist
To Do
N/A