php-http / client-common

Common HTTP Client implementations and tools for HTTPlug
http://httplug.io
MIT License
1.03k stars 54 forks source link

PHPUnit is missing as dev-dependency and in CI #182

Closed Headd2k closed 4 years ago

Headd2k commented 4 years ago

i was going to analyze a behavior in the library regarding the redirect plugin and was going to utilize phpunit to see whats going on. i was happy to see that there are already some phpunit tests existing that are also relatively new to the project but i had to install phpunit and nyholm/psr7 manually as dev dependency and fix the existing tests a bit to have the chance to get the existing test running. also i found out that the phpunit tests are currently not part of the ci runs.

so my question is: should i try to build a pr that adds the missing dev dependencies and also executes the phpunit tests on ci?