search

php-http / client-common

Common HTTP Client implementations and tools for HTTPlug
http://httplug.io
MIT License
1.01k stars 53 forks source link

Dependency: Symfony/options-resolver allow ^6.0 #215

Closed Jeroeny closed 2 years ago

Jeroeny commented 2 years ago
Q A
Bug fix? no
New feature? no
BC breaks? no
Deprecations? no
Related tickets None
License MIT

What's in this PR?

Update composer.json to allow the upcoming ^6.0 for symfony/options-resolver.

Why?

To support Symfony 6.

GrahamCampbell commented 2 years ago

Do the tests pass against symfony 6?

Jeroeny commented 2 years ago

Do the tests pass against symfony 6?

The result is: Tests: 14, Assertions: 24, Warnings: 6., if that was the baseline, then yes.

Output: https://gist.github.com/Jeroeny/acc1ac1fe61927d3cf8951d6310d12a2

dbu commented 2 years ago

thanks!

could you add symfony 6 (and 5 :scream: ) to the build matrix at .github/workflows/tests.yml please?

Jeroeny commented 2 years ago

@dbu 👍 added

dbu commented 2 years ago

thanks!

there seems to have been a change with phpstan but that is definitely not related to your changes. i will merge and look at the phpstan issues separately.

dbu commented 2 years ago

thanks again @Jeroeny , i tagged https://github.com/php-http/client-common/releases/tag/2.5.0 with symfony 6 support.