redirection to different domain must not keep previous port

php-http / client-common

Common HTTP Client implementations and tools for HTTPlug

http://httplug.io

MIT License

1.01k stars 53 forks source link

redirection to different domain must not keep previous port #221

Closed dbu closed 1 year ago

dbu commented 1 year ago

Q	A
Bug fix?	yes
New feature?	no
BC breaks?	no
Deprecations?	no
Related tickets	fixes #219
Documentation	-
License	MIT

What's in this PR?

Correctly handle non-absolute URLs in the redirect

Why?

Conform with RFC 7231 Location header specification

Checklist

[x] Updated CHANGELOG.md to describe BC breaks / deprecations | new feature | bugfix

dbu commented 1 year ago

@ostrolucky can you review this one please? trying to get all of the redirection right. i discovered that besides the domain/scheme/port topic, RFC 7231 also allows relative paths with all of the path semantics...

dbu commented 1 year ago

thanks for the feedback. i updated all points you discovered