search

php-http / client-common

Common HTTP Client implementations and tools for HTTPlug
http://httplug.io
MIT License
1.01k stars 53 forks source link

chore: add testrun for symfony 7 #237

Closed Chris53897 closed 7 months ago

Chris53897 commented 7 months ago

Please see https://github.com/php-http/client-common/pull/232#issuecomment-1833494282

Support for Symfony 7 is added in "phpspec/phpspec" 7.5.0 https://github.com/phpspec/phpspec/releases/tag/7.5.0

dbu commented 7 months ago

something is not working with those "LTS" builds - https://github.com/php-http/client-common/actions/runs/7600541313/job/20722422472?pr=237 is the one that says symfony 7, but it installs symfony 3 things :scream:

we should probably set up flex with shivammatur like they do here https://github.com/doctrine/DoctrineBundle/commit/42f5834825eaa967af833722c336d5dd05cbd4f3 and make sure the major version is enforced.

dbu commented 7 months ago

the problem with the current setup: we install flex at the same time as updating the dependencies, so flex is not yet present and does not enforce versions.

Chris53897 commented 7 months ago

@dbu I think composer global was the missing part. But maybe you are right too. Because i did remove more parts, because i think they are obsolete. Please have a look if i did it correct.

I changed Symfony LTS according to the real LTS. https://symfony.com/releases