search

php-http / client-common

Common HTTP Client implementations and tools for HTTPlug
http://httplug.io
MIT License
1.03k stars 54 forks source link

PhpDoc: missing attribute 'stream_factory' #244

Closed Chris53897 closed 10 months ago

Chris53897 commented 10 months ago

https://github.com/php-http/client-common/blob/2.x/src/Plugin/RedirectPlugin.php#L116

I guess the correct one is this. (or FQCN) @param array{'preserve_header'?: bool|string[], 'use_default_for_multiple'?: bool, 'strict'?: bool, 'stream_factory'?:StreamFactoryInterface} $config

dbu commented 10 months ago

oh right. yes your suggestion looks right. i think the tools that understand array shapes also understand use, so the short name is better to keep it readable.

dbu commented 10 months ago

fixed in #245