search

php-http / curl-client

cURL client
http://httplug.io
MIT License
443 stars 28 forks source link

we don't support php 5.4 #2

Closed dbu closed 8 years ago

dbu commented 8 years ago

i activated travis for this repository and noticed it tries to build with php 5.4, then composer notices that this wont work.

i suggest we activate php 7 as well. its about to be released, and currently green.

dbu commented 8 years ago

hm, but hhvm setup seems to be broken

sagikazarmark commented 8 years ago

HHVM is an ugly bitch IMHO when it comes to cURL. PHP 7 can be enabled for this repo, but not for others, where PHPSpec is used, as 2.4 is not stable yet.

mekras commented 8 years ago

I have never dealt with HHVM. So I just copied existed setup from boilerplate.

dbu commented 8 years ago

i will see what i can do about HHVM

sagikazarmark commented 8 years ago

As I can see, there is a problem with the integration test suite.

dbu commented 8 years ago

there seems to also be an issue with the lowest version getting a too old version of phpunit token stream

mekras commented 8 years ago

Code coverage fixed.

mekras commented 8 years ago

Tests currently needs PHP builtin server. So they can not run under HHVM. Add skipping them for now.