search

php-http / curl-client

cURL client
http://httplug.io
MIT License
443 stars 28 forks source link

Minimize memory usage when reading large response body #20

Closed mekras closed 8 years ago

mekras commented 8 years ago

Requires https://github.com/php-http/message/pull/40.

sagikazarmark commented 8 years ago

Tagged v1.2.0

mekras commented 8 years ago

When downloading a 50 MiB file, the peak memory usage is reduced from 198 MiB to 2.22 MiB.

dbu commented 8 years ago

When downloading a 50 MiB file, the peak memory usage is reduced from 198 MiB to 2.22 MiB.

wow, massive!

mekras commented 8 years ago

Thanks to @jack-theripper.

sagikazarmark commented 8 years ago

Nice job :+1:

xabbuh commented 8 years ago

What about tagging this also als 1.3.1? Imo this can safely be treated as a bug fix (as well as the other changes done since the release of 1.3.0).

mekras commented 8 years ago

I thought about it. But the change is pretty significant, actually rewritten the entire stream related part. I think that is a sufficient reason to change the minor version.

dbu commented 8 years ago

i agree with that decision, minor versions are ok even when no real new features are introduced. a minor version means that updating is not trivial and requires more testing - which is the case here then.