search

php-http / curl-client

cURL client
http://httplug.io
MIT License
445 stars 28 forks source link

Support PSR-18 #43

Closed Nyholm closed 6 years ago

Nyholm commented 6 years ago

This will require a new major version. We do not have to release 2.0 right after merging this PR but we should release 2.0 this year.

This is just a "technical" BC break. We could consider other changes as well.

joelwurtz commented 6 years ago

If this require a new major version why not requiring the psr only?

EDIT : In fact may be better in a 3.0 so we let time for people to upgrade to the psr

joelwurtz commented 6 years ago

Base on the previous comment by @xabbuh it seems that this is not possible @dbu, as it induces an interface being implemented twice and so it throws an error.

xabbuh commented 6 years ago

yes, see https://3v4l.org/Drbl2

xabbuh commented 6 years ago

We should probably create a 1.x branch before merging here and add a branch alias entry in the composer.json file here.

dbu commented 6 years ago

i created the 1.7 branch from current master, and added the branch alias to this PR.

dbu commented 6 years ago

\o/