search

php-http / curl-client

cURL client
http://httplug.io
MIT License
445 stars 28 forks source link

curl_strerror and HHVM #6

Closed mekras closed 8 years ago

mekras commented 8 years ago

MultiRunner class uses function curl_strerror, which is not supported by HHVM.

sagikazarmark commented 8 years ago

We could create a polyfill for it.

mekras commented 8 years ago

And how to load it? I have never deal with HHVM.

sagikazarmark commented 8 years ago

I would make it a separate repository, something like this: https://github.com/indigophp/hash-compat

You can simply check if the function exists or not, as in the linked repo.

You can install it as a development dependency to make the builds green and put it in the suggest section for HHVM.

dbu commented 8 years ago

in the plugins we said hhvm is not a priority. imho its ok to put hhvm into the allowed failures for the build and add a note in the documentation that this currently does not work with hhvm.

if you want to make it work, maybe look how guzzle is doing this, if they do at all support guzzle.