search

php-http / curl-client

cURL client
http://httplug.io
MIT License
443 stars 28 forks source link

PHP 8 Support #68

Closed GrahamCampbell closed 3 years ago

GrahamCampbell commented 4 years ago

This will require some work, since the curl functions no longer return resources.

dbu commented 4 years ago

we might want to do a next major version that only works with php 8 then. or wrap resources / the php 8 thing in some abstraction, but that sounds like quite some effort.

GrahamCampbell commented 4 years ago

Not necessarily. We should be able to doc resource|CurlHandle. They behave almost the same.

ildyria commented 3 years ago

I am sorry to bump the issue, but now that PHP 8 is live. This package becomes one of the blocking for others e.g. https://github.com/geocoder-php/Geocoder

GrahamCampbell commented 3 years ago

@ildyria You can prepare a PR of you like.

GrahamCampbell commented 3 years ago

I don't see why this should be a blocker for them anyway. They can use any http client, if they are using this curl-client. They should swap out their curl-client dependency for a virtual dependency, so that any http client can be used.

dbu commented 3 years ago

geocoder does properly reference the virtual package, but uses curl-client in require-dev for their testing.

but yep, we all agree that it would be useful to do it. now its the question of finding somebody who wants to invest the time to make it happen. i don't have that time right now, but would be happy to review a pull request and can tag the release once its merged.

ildyria commented 3 years ago

@ildyria You can prepare a PR of you like.

Already started working on it this morning, but I don't have the time to dig more (more pressing matters at hand). Nevertheless I used GitHub actions to quickly replicate the behavior of your travis.yml file and quickly start on testing (pretty simple set-up). You can find my finding here:

https://github.com/ildyria/curl-client/actions/runs/391280741