php-http / curl-client

cURL client
http://httplug.io
MIT License
445 stars 28 forks source link

full support to PHP 8.0 + add support for CurlHandle resource objects #71

Closed ildyria closed 3 years ago

ildyria commented 3 years ago
Q A
Bug fix? yes
New feature? no
BC breaks? no
Deprecations? no
Related tickets fixes #68, closes #70
Documentation -
License MIT

What's in this PR?

Why?

Example Usage

is_resource(curl_init()); // true in PHP < 8.0
is_resource(curl_init()); // false in PHP >= 8.0
ildyria commented 3 years ago

@dbu I incorporated your suggestions to #70 in this PR.

ildyria commented 3 years ago

Full CI run here: https://github.com/ildyria/curl-client/actions/runs/413449950

ildyria commented 3 years ago

@dbu fixed as per requested.

CI Run here: https://github.com/ildyria/curl-client/actions/runs/416459080 I enabled coverage as per the travis file, but I expect it to crash as I don't have access to the secrets in the repo.

dbu commented 3 years ago

thanks a lot, this is coming good!

as you expected, the coverage fails in your repository. i will merge and see if it works from our repository.

dbu commented 3 years ago

thanks for the review graham - i was so excited for php 8 that i missed those details. i do a cleanup in #74

Ayesh commented 3 years ago

Author of #70 - thank you for picking up it in here, I'm happy to see it merged now. I apologize about my delays in the other PR, I was having some issues lately. 🙏🏼

dbu commented 3 years ago

thanks for having gotten the ball rolling @Ayesh and @ildyria for wrapping it up. collaboration for the win!