php-http / discovery

Finds installed clients and message factories
http://php-http.org
MIT License
1.26k stars 47 forks source link

WIP: Add suport for Amphp PSR18 Client #257

Open thePanz opened 9 months ago

thePanz commented 9 months ago

Note: the use Amp\Http\Client\Psr7\PsrHttpClient is still a WIP, and the support for PSR-18 has been added only on the v2 branch

Only on that branch the PsrHttpClient is implementing the ClientInterface

Note: The library only supports the psr/http-message:v1 contract

Q A
Bug fix? no
New feature? yes
BC breaks? no
Deprecations? no
Related tickets fixes #240
Documentation if this is a new feature, link to pull request in https://github.com/php-http/documentation that adds relevant documentation
License MIT

What's in this PR?

Implement support for amphp/http-client-psr7

Some notes:

  1. the amphp/http-client-psr7 main branch is NOT implementing the PSR ClientInterface
  2. the v2.x branch is effectively implements the PSR ClientInterface, but relies on psr/http-message v1
  3. looks like the PSR layer is not actively maintainer (master last commit: 3 years ago, v2.x last commit: 2 years ago)
  4. there is a PR bringing the library up https://github.com/amphp/http-client-psr7/pull/10 by @danog but not merged

Checklist

To Do

nicolas-grekas commented 4 months ago

Linked PR is now merged. Until https://github.com/amphp/http-client-psr7/pull/10#issuecomment-2068752454 is resolved, this should also install guzzle's PSR-7.