search

php-http / discovery

Finds installed clients and message factories
http://php-http.org
MIT License
1.26k stars 47 forks source link

Since 1.19.3, this package is downgrading dependencies due to sebastian/comparator #265

Closed michaelarnauts closed 5 months ago

michaelarnauts commented 5 months ago

PHP version: 8.3.4

Description Since the release of 1.19.3 (with this change: https://github.com/php-http/discovery/pull/264), it seems the composer doesn't allow sebastian/comparator 5.x anymore and insists on downgrading sebastian/comparator to 4.0.8, dragging a lot of dependencies with it.

I wonder if the conflicts before didn't actually work, and still allowed sebastian/comparator 5.0.1.

$ composer update --dry-run
Composer could not detect the root package (dstny/doss-ordering) version, defaulting to '1.0.0'. See https://getcomposer.org/root-version
Loading composer repositories with package information
Updating dependencies
Lock file operations: 0 installs, 25 updates, 0 removals
  - Downgrading codeception/lib-innerbrowser (4.0.3 => 3.1.3)
  - Upgrading php-http/discovery (1.19.2 => 1.19.3)
  - Downgrading phpunit/php-code-coverage (10.1.14 => 9.2.31)
  - Downgrading phpunit/php-file-iterator (4.1.0 => 3.0.6)
  - Downgrading phpunit/php-invoker (4.0.0 => 3.1.1)
  - Downgrading phpunit/php-text-template (3.0.1 => 2.0.4)
  - Downgrading phpunit/php-timer (6.0.0 => 5.0.3)
  - Downgrading phpunit/phpunit (10.5.14 => 9.6.18)
  - Downgrading sebastian/cli-parser (2.0.1 => 1.0.2)
  - Downgrading sebastian/code-unit (2.0.0 => 1.0.8)
  - Downgrading sebastian/code-unit-reverse-lookup (3.0.0 => 2.0.3)
  - Downgrading sebastian/comparator (5.0.1 => 4.0.8)
  - Downgrading sebastian/complexity (3.2.0 => 2.0.3)
  - Downgrading sebastian/diff (5.1.1 => 4.0.6)
  - Downgrading sebastian/environment (6.0.1 => 5.1.5)
  - Downgrading sebastian/exporter (5.1.2 => 4.0.6)
  - Downgrading sebastian/global-state (6.0.2 => 5.0.7)
  - Downgrading sebastian/lines-of-code (2.0.2 => 1.0.4)
  - Downgrading sebastian/object-enumerator (5.0.0 => 4.0.4)
  - Downgrading sebastian/object-reflector (3.0.0 => 2.0.4)
  - Downgrading sebastian/recursion-context (5.0.0 => 4.0.5)
  - Downgrading sebastian/type (4.0.0 => 3.2.1)
  - Downgrading sebastian/version (4.0.1 => 3.0.2)
  - Downgrading symfony/browser-kit (v7.0.3 => v6.4.3)
  - Downgrading symfony/dom-crawler (v7.0.4 => v6.4.4)

How to reproduce

do a composer update on a project that is using this package (as a dependency somewhere)

Possible Solution

Additional context

dbu commented 5 months ago

264 is not included in the release. the regression happened in #255 - the #264 fixes it again. i will tag a new patch release now

dbu commented 5 months ago

fixed in release https://github.com/php-http/discovery/releases/tag/1.19.4