search

php-http / documentation

Documentation for PHP-HTTP including HTTPlug
http://docs.php-http.org
MIT License
23 stars 55 forks source link

Update Pipfile #290

Closed dbu closed 3 years ago

dbu commented 3 years ago

the search on readthedocs is broken and there is a jquery error when loading the page.

we seem to use very old versions of sphinx and its dependencies. lets see if upgrading helps.

fix #289

Xenonym commented 3 years ago

@dbu I don't think the CI process is working. Is Travis even required? The last PR I made (#288) seem to deploy just fine.

The ability to preview changes doesn't seem to be tied to Travis either - having this enabled would cover most of the needs for having a CI process in a documentation project like this.

dbu commented 3 years ago

thanks, i managed to make readthedocs build the branch. it seems to build with these changes, but the search is still broken: https://php-http--290.org.readthedocs.build/en/290/

the log of the build seems to be here: https://readthedocs.org/api/v2/build/14728001.txt

if you have any idea, i appreciate input. otherwise i will try to look into it but can't promise when i get to it.

Xenonym commented 3 years ago

@dbu RTD is using requirements.txt instead of Pipfile and defaulting to Python 2:

[rtd-command-info] start-time: 2021-09-16T06:28:20.743105Z, end-time: 2021-09-16T06:28:25.838423Z, duration: 5, exit-code: 0
/home/docs/checkouts/readthedocs.org/user_builds/php-http/envs/290/bin/python -m pip install --exists-action=w --no-cache-dir -r requirements.txt
DEPRECATION: Python 2.7 reached the end of its life on January 1st, 2020. Please upgrade your Python as Python 2.7 is no longer maintained. pip 21.0 will drop support for Python 2.7 in January 2021. More details about Python 2 support in pip can be found at https://pip.pypa.io/en/latest/development/release-process/#python-2-support pip 21.0 will remove support for this functionality.

It doesn't seem like RTD has ever supported Pipenv from the start: https://github.com/readthedocs/readthedocs.org/issues/3181

The version of PIP used in RTD should support Poetry via PEP 517, if you are so inclined, or we could just use requirements.txt and specify Python 3 in .readthedocs.yaml for simplicity.

dbu commented 3 years ago

thanks for the ping-pong! i think i found a working solution with recent versions of the stuff. and the search seems fixed \o/