search

php-http / httplug

HTTPlug, the HTTP client abstraction for PHP
http://httplug.io
MIT License
2.57k stars 39 forks source link

stop building with hhvm because it stopped working #146

Closed dbu closed 6 years ago

dbu commented 6 years ago

it seems a recent version of hhvm did a BC break, builds that have been successful now fail with

Fatal error: Uncaught TypeError: Argument 1 passed to spec\Http\Client\Exception\HttpExceptionSpec::let() 
must implement interface Psr\Http\Message\RequestInterface, PhpSpec\Wrapper\Collaborator given
 in /home/travis/build/php-http/httplug/spec/Exception/HttpExceptionSpec.php:14
Q A
Bug fix? no
New feature? no
BC breaks? no
Deprecations? no
Related tickets -
Documentation -
License MIT

What's in this PR?

Drop HHVM support

Why?

HHVM build stopped working, and HHVM seems not relevant enough anymore to figure out why.

Checklist

no changelog entry and no doc change needed.