php-http / httplug

HTTPlug, the HTTP client abstraction for PHP
http://httplug.io
MIT License
2.57k stars 39 forks source link

Add exception explanation, fixes #87 #93

Closed sagikazarmark closed 8 years ago

sagikazarmark commented 8 years ago

@dbu @joelwurtz please help me with the explanation. :smile:

dbu commented 8 years ago

looks good to me. for async, we could mention in the text part that exceptions that should be handled like network issues and server problems are available from the promise, as they might not be known yet when the sendAsyncRequest method returns.

sagikazarmark commented 8 years ago

Better now?

(Should be squashed)

dbu commented 8 years ago

looks good to me, yes!

sagikazarmark commented 8 years ago

@joelwurtz ping

joelwurtz commented 8 years ago

Aside from my comment, :+1: for me