remove request/response value objects from log context

php-http / logger-plugin

PSR-3 Logger plugin for HTTPlug

http://docs.php-http.org/en/latest/plugins/logger.html

MIT License

282 stars 7 forks source link

remove request/response value objects from log context #20

Closed ro0NL closed 2 years ago

ro0NL commented 2 years ago

Q	A
Bug fix?	no
New feature?	yes
BC breaks?	no
Deprecations?	no
Related tickets	related to #16
Documentation	-
License	MIT

krewetka commented 2 years ago

In my opinion you cannot say it fixed #16 when the reported problem there is Request and response in context always empty and your MR is removing it from context.

The other thing is what we discussed inside the thread there but really hard to say it fixes problem reported by author :)

I am not against this MR by any means, just description is not really accurate.