search

php-http / message-factory

Abandoned: Httplug Factory interfaces for PSR-7 HTTP Message
http://php-http.org
MIT License
1.38k stars 10 forks source link

Test on PHP 8 #41

Open GrahamCampbell opened 4 years ago

GrahamCampbell commented 4 years ago

There is no upper bound on the PHP version (and too late to add one in 1.x). We should test on PHP 8.0 with the CI.

dbu commented 4 years ago

i wonder if we don't want to add the upper bound anyways. then at least in the future, we are more robust.

GrahamCampbell commented 4 years ago

An upperbound would be a good idea, because almost certainly PHP 9 will have totally deleted the concept of a resource, so things like https://github.com/php-http/message-factory/blob/master/src/StreamFactory.php#L17 need updating with whatever the replacement for fopen's return type is, and related types.