search

php-http / message

HTTP Message related tools
http://php-http.org
MIT License
1.29k stars 41 forks source link

Remove internal deprecation notice #101

Closed joelwurtz closed 5 years ago

joelwurtz commented 6 years ago
Q A
Bug fix? yes
New feature? no
BC breaks? no
Deprecations? no
Related tickets fixes #78
Documentation
License MIT

This remove internal deprecation notices and still respect bc promise, by implementing construct in each implementation.

Nyholm commented 6 years ago

I see that this removes the deprecation warning when using ie CompressStream. If Im correct, a user that uses the CompressStream wil not notice any difference in 2.0, right? The $writeFilterCallback property is never used... anywhere.

joelwurtz commented 6 years ago

Not sure how this was used, so i made this to be fully BC compatible, but we can remove setting this value if you want

Nyholm commented 6 years ago

Im fine with the current implementation. I just wanted to make sure.

GrahamCampbell commented 5 years ago

Any news on this?

dbu commented 5 years ago

i have no experience with the php stream code, so i don't feel confident enough to merge this one. if people agree that this is the right way to do it, lets merge it.