search

php-http / message

HTTP Message related tools
http://php-http.org
MIT License
1.3k stars 42 forks source link

Test on php 7.3 #107

Closed Nyholm closed 5 years ago

dbu commented 5 years ago

is there a change in php 7.2 that messes up our chunk stream? or only the test for the chunk stream?

joelwurtz commented 5 years ago

From what i have seen it seems that stream_set_chunk_size does not work like before in php 7.2. Don't know what change but this is only explanation possible.

And i don't know a way to mimick this behavior, should we just skip this test ?

joelwurtz commented 5 years ago

Ok, after some search it's coming from fread which now better respect length pass to it #110 should fix those tests

dbu commented 5 years ago

can you please rebase on master now that the chunk issue should be fixed?

joelwurtz commented 5 years ago

I think tests are played on the merged version and since there are green we can safely merge this ?

dbu commented 5 years ago

thanks. indeed, restarting the tests was enough.