search

php-http / message

HTTP Message related tools
http://php-http.org
MIT License
1.29k stars 41 forks source link

Fix fatal error for long bodies #116

Closed GaryPEGEOT closed 5 years ago

GaryPEGEOT commented 5 years ago
Q A
Bug fix? yes
New feature? no
BC breaks? no
Deprecations? no
Related tickets fixes #93
Documentation
License MIT

What's in this PR?

Prevent CurlCommandFormatter to throw a Fatal exception when body size exceed escapeshellarg argument allowed length. Didn't find a great way to get the limit tho... Windows limit come from PHP source code, the UNIX from 

echo $(getconf ARG_MAX)

If you have a better solution to find escapeshellarg limit, I'm all ears

Checklist

GaryPEGEOT commented 5 years ago

maybe lets just limit to 8192 and say that this should work on all operating systems. wdyt?

Totally agree, it's neither user friendly nor memory friendly

dbu commented 5 years ago

thanks!

dbu commented 5 years ago

released 1.8.0 with this and some other fixes.