search

php-http / message

HTTP Message related tools
http://php-http.org
MIT License
1.3k stars 42 forks source link

Add GitHub actions #122

Closed sagikazarmark closed 4 years ago

sagikazarmark commented 4 years ago

Closes #119

sagikazarmark commented 4 years ago

Do we agree with the style changes in this PR? I just used symfony, minus the rule mentioned in #119

dbu commented 4 years ago

whats up with travis-ci?

sagikazarmark commented 4 years ago

I removed the travis config, so it won't build this branch (and master after merging).

@dbu If you agree with the changes we can merge this PR and disable the required check for travis.

dbu commented 4 years ago

is this a new problem or general about php 7.4? https://github.com/php-http/message/pull/122/checks?check_run_id=367925137

sagikazarmark commented 4 years ago

is this a new problem or general about php 7.4?

What do you mean exactly? It's a successful check.

dbu commented 4 years ago

https://github.com/php-http/message/pull/122/checks?check_run_id=367925137 What do you mean exactly? It's a successful check.

when you open the "Run tests" bit, it is full of warnings:

PHP Warning:  require_once(): PhpSpec\Loader\StreamWrapper::stream_set_option is not implemented! in /home/runner/work/message/message/vendor/phpspec/phpspec/src/PhpSpec/Loader/ResourceLoader.php on line 52
PHP Stack trace:
PHP   1. {main}() /home/runner/work/message/message/vendor/phpspec/phpspec/bin/phpspec:0
PHP   2. PhpSpec\Console\Application->run() /home/runner/work/message/message/vendor/phpspec/phpspec/bin/phpspec:26
PHP   3. PhpSpec\Console\Application->doRun() /home/runner/work/message/message/vendor/symfony/console/Application.php:148
PHP   4. PhpSpec\Console\Application->doRun() /home/runner/work/message/message/vendor/phpspec/phpspec/src/PhpSpec/Console/Application.php:104
PHP   5. PhpSpec\Console\Application->doRunCommand() /home/runner/work/message/message/vendor/symfony/console/Application.php:255
PHP   6. PhpSpec\Console\Command\RunCommand->run() /home/runner/work/message/message/vendor/symfony/console/Application.php:1000
PHP   7. PhpSpec\Console\Command\RunCommand->execute() /home/runner/work/message/message/vendor/symfony/console/Command/Command.php:255
PHP   8. PhpSpec\Loader\ResourceLoader->load() /home/runner/work/message/message/vendor/phpspec/phpspec/src/PhpSpec/Console/Command/RunCommand.php:168