search

php-http / message

HTTP Message related tools
http://php-http.org
MIT License
1.29k stars 41 forks source link

Add mixed return type to `StreamInterface::getMetadata` #161

Closed ruudk closed 6 months ago

ruudk commented 6 months ago
Q A
Bug fix? yes
New feature? no
BC breaks? no
Deprecations? no
Related tickets
Documentation
License MIT

What's in this PR?

Fixes the following error caught by Symfony's PHPUnit Bridge:

  1x: Method "Psr\Http\Message\StreamInterface::getMetadata()" might add "mixed" as a native return type declaration in the future. Do the same in implementation "Http\Message\Encoding\FilteredStream" now to avoid errors or add an explicit @return annotation to suppress this message.

Checklist

ruudk commented 6 months ago

@dbu Today, Symfony started to complain about this. I have no idea how we didn't caught this earlier. Could you approve the workflow so that we can patch this, thanks! 🙌

dbu commented 6 months ago

https://github.com/php-http/message/releases/tag/1.16.1