search

php-http / message

HTTP Message related tools
http://php-http.org
MIT License
1.29k stars 41 forks source link

Single header line parsing extracted to a separate method in ResponseBuilder #40

Closed mekras closed 8 years ago

mekras commented 8 years ago

Allows more flexible use of the class.

sagikazarmark commented 8 years ago

LGTM. Wonder if we should add more tests for the addHeader method separately.

mekras commented 8 years ago

@sagikazarmark, may be. But a) new method is fully covered with existed tests; b) I don't feel familiar enough with phpspec.

sagikazarmark commented 8 years ago

Ok. Lemme check if I can do something on this front during the weekend.

joelwurtz commented 8 years ago

:+1: LGTM