Rewind streams - Githubissues

php-http / message

HTTP Message related tools

http://php-http.org

MIT License

1.29k stars 41 forks source link

Rewind streams #47

Closed Nyholm closed 8 years ago

Nyholm commented 8 years ago

Q	A
Bug fix?	yes
New feature?	~~yes~~ no
BC breaks?	no
Deprecations?	no
Related tickets	fixes #46
Documentation	n/a
License	MIT

What's in this PR?

We rewind streams if we can.
We do not read streams if maxBodyLength is 0
We do not read streams we can rewind.

dbu commented 8 years ago

looks good to me! i would consider this a bugfix btw, not a new feature. master already has its branch-alias at 1.4 but no commits since 1.3 so we can simply tag 1.3.1 on master once this is merged.

Nyholm commented 8 years ago

Agreed. This is a bugfix.

sagikazarmark commented 8 years ago

Can you please add changelog for this?

Nyholm commented 8 years ago

Of course!

Nyholm commented 8 years ago

Thank you for the quick review.