search

php-http / message

HTTP Message related tools
http://php-http.org
MIT License
1.3k stars 42 forks source link

Improve package #48

Closed sagikazarmark closed 8 years ago

sagikazarmark commented 8 years ago
Q A
Bug fix? no
New feature? no
BC breaks? no
Deprecations? no
License MIT

What's in this PR?

Improve some package files.

sagikazarmark commented 8 years ago

@php-http/owners any idea why StyleCI suddenly gone mad?

/cc @grahamcampbell

GrahamCampbell commented 8 years ago

StyleCI is doing one build for a PR, and one for a push, exactly like Travis does.

See https://blog.alt-three.com/new-pr-analysis-system/ for more details.

sagikazarmark commented 8 years ago

@GrahamCampbell analysis was okay until yesterday, now it wants to remove trailing period from docblocks: https://styleci.io/repos/48317882

GrahamCampbell commented 8 years ago

Ah, right. That's a change to the symfony CS. They made this change in their codebase very recently, and our rules have been updated accordingly.

GrahamCampbell commented 8 years ago

I actually forgot to regen our docs website after the last deploy. I'll do that now!

sagikazarmark commented 8 years ago

Do you have a PR/link where they introduced this change? Just for reference in our boilerplate and I would like to see some reasoning too if any. Thanks.

GrahamCampbell commented 8 years ago

Of course. Here you are: https://github.com/symfony/symfony/pull/19198.

GrahamCampbell commented 8 years ago

That said, it does look like they specifically are only removing the dots from param and return annotations. I will look into this.

sagikazarmark commented 8 years ago

Thanks for the quick response.