search

php-http / message

HTTP Message related tools
http://php-http.org
MIT License
1.29k stars 41 forks source link

Added cURL formatter #50

Closed Nyholm closed 8 years ago

Nyholm commented 8 years ago
Q A
Bug fix? no
New feature? yes
BC breaks? no
Deprecations? no
Related tickets #19
Documentation
License MIT

What's in this PR?

This will add a cURL formatter

dbu commented 8 years ago

did you look at https://github.com/namshi/cuzzle ? if so we should probably mention the authors of that in the class docblock.

is there anything in namshi that we are missing here?

Nyholm commented 8 years ago

I did not. Haven't seen this package until now. They have somethings we dont.. I'll update the PR.

Nyholm commented 8 years ago

I've update the PR with some fixes borrowed from Cuzzle. See the diff.

It is not too much code. Should I mention the Cuzzle authors?

sagikazarmark commented 8 years ago

Should I mention the Cuzzle authors?

Just mention in the README in a credits section that it is inspired by cuzzle.

https://github.com/php-http/guzzle6-adapter#credits

dbu commented 8 years ago

thanks a lot! created https://github.com/php-http/documentation/issues/136 about documenting this. we might also want to enable it in HttplugBundle

Nyholm commented 8 years ago

Thank you for merging.

👍

sagikazarmark commented 8 years ago

Thanks a lot @Nyholm