php-http / message

HTTP Message related tools
http://php-http.org
MIT License
1.3k stars 42 forks source link

Added Slim to puli.json #55

Closed Nyholm closed 8 years ago

Nyholm commented 8 years ago
Q A
Bug fix? no
New feature? yes
BC breaks? no
Deprecations? no
Related tickets
Documentation
License MIT

Slim factories need to be in puli.json.

For future reference. This is how I did. (Ping @tuupola)

$ php puli.phar bind -f Http\\Message\\MessageFactory\\SlimMessageFactory Http\\Message\\MessageFactory
$ php puli.phar bind -f Http\\Message\\MessageFactory\\SlimMessageFactory Http\\Message\\ResponseFactory
$ php puli.phar bind -f Http\\Message\\MessageFactory\\SlimMessageFactory Http\\Message\\RequestFactory
$ php puli.phar bind -f Http\\Message\\StreamFactory\\SlimStreamFactory Http\\Message\\StreamFactory
$ php puli.phar bind -f Http\\Message\\UriFactory\\SlimUriFactory Http\\Message\\UriFactory   
tuupola commented 8 years ago

Am I correct that for discovery to work without Puli Slim factories should also be added here?

https://github.com/php-http/discovery/blob/master/src/Strategy/CommonClassesStrategy.php

sagikazarmark commented 8 years ago

Yes, you are.