search

php-http / message

HTTP Message related tools
http://php-http.org
MIT License
1.3k stars 42 forks source link

Fix cookie root path match for subdirectories. Refs #65 #66

Closed Maff- closed 7 years ago

Maff- commented 7 years ago
Q A
Bug fix? yes
New feature? no
BC breaks? no?
Deprecations? no
Related tickets fixes #65
License MIT

What's in this PR?

Fixes the problem where (new Cookie('foo', 'bar', null, null, '/'))->matchPath('/cookie') would return false.

Checklist

sagikazarmark commented 7 years ago

Hi there,

Thanks for the PR.

Since the master branch already has some deprecations, which would require an 1.5 release, I cherry-picked your commit to an 1.4.x branch, you can see it here: https://github.com/php-http/message/commit/5fd6c761b994b16afaae4a236abb650e5a068b5a

sagikazarmark commented 7 years ago

And tagged 1.4.1

Maff- commented 7 years ago

Thanks for the quick action!