search

php-http / message

HTTP Message related tools
http://php-http.org
MIT License
1.29k stars 41 forks source link

Make sure we do not rewind a non-seekable stream #71

Closed Nyholm closed 7 years ago

Nyholm commented 7 years ago
Q A
Bug fix? yes
New feature? no
BC breaks? no
Deprecations? no
Related tickets Relates to #72
Documentation
License MIT

What's in this PR?

If we try to create a stream from a non-seekable resource we should not throw an exception.

joelwurtz commented 7 years ago

I'm not sure we really want to rewind a stream, IMO this logic should be handled by the user providing the stream.

Nyholm commented 7 years ago

I was unsure about this as well. That is why I created #72.

dbu commented 7 years ago

the fix in itself is save, and good. lets discuss the general question of rewinding in #72

Nyholm commented 7 years ago

Thank you for merging