Closed ste93cry closed 7 years ago
@ste93cry when you address the feedback from tobias, please also rebase on master - there is a conflict with the CHANGELOG file that will prevent automatic merging.
Thank you @ste93cry for your responses.
What I do not like about this PR is that we list a bunch of filters (and it is missing tests). This is a "workaround" and not a "fix".
I have submitted some PRs to the clue/php-stream-filter in order to actually fix this problem. I hope you are okey with closing this PR update our dependencies to the next version of that library?
I hope you are okey with closing this PR update our dependencies to the next version of that library?
I agree that fixing this upstream is a better solution that this PR, so it's fine. Just for reference in case someone lands here in the future, the ticket related to this problem is clue/php-stream-filter#15
What's in this PR?
In this PR the
$writeFilterOptions
argument of theFilteredStream::__construct
method is normalized because some built-in PHP stream filters doesn't acceptnull
as options. As a consequence of this, the deprecation message was triggered in some cases when it should not had to, and this has been addressed too. I'm not sure about the entry I added in the CHANGELOG, as I'm not a native English speaker maybe you can find a better phrase... I don't know if unit tests are needed for this PR as currently there is nothing hat tests the throwing of the error or the call to theFilter\fun
function with the correct arguments. Ast a last thing, I can't test what options thebzip2.compress
andbzip2.decompress
accept, so the PR is not ready yet until someone finds out ifnull
is a valid value or not.Checklist