search

php-http / utils

[DEPRECATED] HTTP Client Utilities
http://httplug.io
MIT License
2 stars 8 forks source link

expose underlying HttpClient methods in HttpMethodsClient #10

Closed dbu closed 9 years ago

dbu commented 9 years ago

fix #7

sagikazarmark commented 9 years ago

Why is the send method protected? I think it should be public.

sagikazarmark commented 9 years ago

:+1:

dbu commented 9 years ago

i did not change that. hm, but good question. the use case would be custom HTTP methods? probably makes sense, will change that.

i ran the tests locally. can we enable travis for this repo? the .travis.yml file is present already.

sagikazarmark commented 9 years ago

I know you didn't change that, just spotted it now.

Custom HTTP methods, GET requests with body.

Travis enabled.

dbu commented 9 years ago

made send public. now we also have a way to GET with a body without using the message factory. exposing the underlying HttpClient still makes sense.

sagikazarmark commented 9 years ago

:+1:

dbu commented 9 years ago

ups, i will try to fix the build.