search

php-imagine / Imagine

PHP Object Oriented image manipulation library
https://imagine.readthedocs.io
Other
4.42k stars 529 forks source link

Fixes #715: Silenced call to \Imagick::setImageOpacity() #716

Closed samdark closed 5 years ago

samdark commented 5 years ago

In order to prevent deprecation error with PECL 3.4.4 and ImageMagick 6.

See #715

samdark commented 5 years ago

Hmm. Seems it doesn't silence. Weird...

samdark commented 5 years ago

That's PHPUnit.

samdark commented 5 years ago

Now it's all green including AppVeyor.

samdark commented 5 years ago

Ready to be merged.

mlocati commented 5 years ago

I'd intercept the E_DEPRECATED notice in the src/Imagick/Imagine.php class, instead of hiding these notices for the whole tests.

Why?

  1. this may hide future deprecations
  2. when this library is used in production sites, they may log these warnings, unnecessarily

Solution? What about wrapping that call in a withExceptionHandler like we already do in the Gd\Image class?

samdark commented 5 years ago

Doesn't seem to work like that. Have no idea how to do it without using @.

samdark commented 5 years ago

@mlocati any suggestions?

mlocati commented 5 years ago

717 should fix this issue

samdark commented 5 years ago

Great. Do you plan tagging release?

mlocati commented 5 years ago

Yep, as soon as I find a minute to do that (I guess in an hour or two)

mlocati commented 5 years ago

Great. Do you plan tagging release?

Done