ExifMetadataReader::readFile() does not return Exif data

stevekr commented 4 years ago

Issue description

No Exif data returned when using (new ExifMetadataReader())->readFile($path) while exif_read_data($path, null, true, false) works fine.

What version of Imagine are you using?

1.2.2

What's the PHP version you are using?

7.3.11

What's the imaging library you are using [gd/imagick/gmagick/any]?

any

What's the imaging library configuration

--

Minimal PHP code to reproduce the error:

(new ExifMetadataReader())->readFile($path)

mlocati commented 4 years ago

I did this test:

download https://github.com/ianare/exif-samples/blob/master/tiff/Arbitro.tiff and https://github.com/ianare/exif-samples/blob/master/jpg/Canon_40D.jpg

Execute this code:

print_r((new ExifMetadataReader())->readFile('./Arbitro.tiff'));
print_r((new ExifMetadataReader())->readFile('./Canon_40D.jpg'));

The output is:

So it seems to me that everything is working as expected...

What do you get if you run the following code? var_dump((new ExifMetadataReader())->readFile($path));

stevekr commented 4 years ago

What do you get if you run the following code? var_dump((new ExifMetadataReader())->readFile($path));

I get:

object(Imagine\Image\Metadata\MetadataBag)#6 (1) {
  ["data":"Imagine\Image\Metadata\MetadataBag":private]=>
  array(2) {
    ["uri"]=>
    string(75) "/path/to/image.jpg"
    ["filepath"]=>
    string(75) "/path/to/image.jpg"
  }
}

mlocati commented 4 years ago

Could you post here your image?

ausi commented 4 years ago

You can also try the following line, this is similar to how Imagine reads the EXIF data:

var_dump(exif_read_data('data://image/jpeg;base64,'.base64_encode(file_get_contents($path)), null, true, false));

stevekr commented 4 years ago

This gives me fatal error Uncaught TypeError: exif_read_data() expects parameter 2 to be string, null given.

Update: If I remove declare(strict_types=1); then I get Warning: exif_read_data(): Unable to open file

ausi commented 4 years ago

What do you get when you run var_dump(implode(',', stream_get_wrappers()));?

stevekr commented 4 years ago

string(61) "https,ftps,compress.zlib,php,file,glob,data,http,ftp,zip,phar"

ausi commented 4 years ago

What do you get with the following line?

var_dump(exif_read_data('data://image/jpeg;base64,/9j/4AAQSkZJRgABAQEAYABgAAD/2wBDAAIBAQIBAQICAgICAgICAwUDAwMDAwYEBAMFBwYHBwcGBwcICQsJCAgKCAcHCg0KCgsMDAwMBwkODw0MDgsMDAz/2wBDAQICAgMDAwYDAwYMCAcIDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAz/wAARCAABAAEDASIAAhEBAxEB/8QAHwAAAQUBAQEBAQEAAAAAAAAAAAECAwQFBgcICQoL/8QAtRAAAgEDAwIEAwUFBAQAAAF9AQIDAAQRBRIhMUEGE1FhByJxFDKBkaEII0KxwRVS0fAkM2JyggkKFhcYGRolJicoKSo0NTY3ODk6Q0RFRkdISUpTVFVWV1hZWmNkZWZnaGlqc3R1dnd4eXqDhIWGh4iJipKTlJWWl5iZmqKjpKWmp6ipqrKztLW2t7i5usLDxMXGx8jJytLT1NXW19jZ2uHi4+Tl5ufo6erx8vP09fb3+Pn6/8QAHwEAAwEBAQEBAQEBAQAAAAAAAAECAwQFBgcICQoL/8QAtREAAgECBAQDBAcFBAQAAQJ3AAECAxEEBSExBhJBUQdhcRMiMoEIFEKRobHBCSMzUvAVYnLRChYkNOEl8RcYGRomJygpKjU2Nzg5OkNERUZHSElKU1RVVldYWVpjZGVmZ2hpanN0dXZ3eHl6goOEhYaHiImKkpOUlZaXmJmaoqOkpaanqKmqsrO0tba3uLm6wsPExcbHyMnK0tPU1dbX2Nna4uPk5ebn6Onq8vP09fb3+Pn6/9oADAMBAAIRAxEAPwD9/KKKKAP/2Q==', null, true, false));

stevekr commented 4 years ago

Still Warning: exif_read_data(): Unable to open file

ausi commented 4 years ago

Looks like your installation doesn’t support data URIs even though the data stream wrapper is enabled.

You can verify my assumption by running this: var_dump(file_get_contents('data://text/plain,test'));

stevekr commented 4 years ago

Warning: file_get_contents(): data:// wrapper is disabled in the server configuration by allow_url_fopen=0

ausi commented 4 years ago

If you set allow_url_fopen=1 in your php.ini the issue should get fixed.

stevekr commented 4 years ago

Thanks for helping me debug this. If there is no way to make it work without url fopen enabled, maybe it should be somewhere in the ExifMetadataReader source that it requires allow_url_fopen=1.

mlocati commented 4 years ago

maybe it should be somewhere in the ExifMetadataReader source that it requires allow_url_fopen=1

@stevekr I'm not sure what you mean with this. Could you explain it in other words?

stevekr commented 4 years ago

For example put it in ExifMetadataReader::extract() or class docblock just for a reminder to others who may have similar problem like I did.

mlocati commented 4 years ago

What about something like #729 ?

stevekr commented 4 years ago

Even better :)

ausi commented 4 years ago

I looked up the PHP documentation for data:// and it says “Restricted by allow_url_fopen: No”: https://www.php.net/manual/en/wrappers.data.php

We should probably check if the documentation is wrong or if there is something else at the root of this issue.

mlocati commented 4 years ago

I tried to set allow_url_fopen=1 in my php.ini file (php 7.3.12) and that prevented var_dump(file_get_contents('data://text/plain,test')); from working, so yes, imho there's something wrong, either in the documentation or in the php code (and of course I think that PHP should behave like described in the manual). Are you willing to submit a bug to https://bugs.php.net ?

ausi commented 4 years ago

Are you willing to submit a bug to bugs.php.net ?

Yes, I will. But it will take some time 🙃

mlocati commented 4 years ago

I can do that, if you prefer

ausi commented 4 years ago

That would be great, thanks!

mlocati commented 4 years ago

There's already a bug report: https://bugs.php.net/bug.php?id=47336

I added this comment: https://bugs.php.net/bug.php?id=47336#1575618618

php-imagine / Imagine