Fix GMagick No encode delegate

php-imagine / Imagine

PHP Object Oriented image manipulation library

https://imagine.readthedocs.io

Other

4.42k stars 529 forks source link

Fix GMagick No encode delegate #747

Closed mlocati closed 4 years ago

ausi commented 4 years ago

If I remember correctly from #733 the error didn’t always show up. It seems that this issue only occurs before the first successful save operation for this format happened. Maybe adding @runInSeparateProcess to the test method can help to reveal the issue.

mlocati commented 4 years ago

Maybe adding @runInSeparateProcess to the test method can help to reveal the issue.

Yep, it worked! And also broke PHP with a segfault 🤣

mlocati commented 4 years ago

Any suggestion to fix those Segmentation fault (core dumped) errors is very welcome...

mlocati commented 4 years ago

I tried with https://github.com/avalanche123/Imagine/pull/747/commits/c7dfccd2314536fa448eed68da9b2d97b47f62c5#diff-4c0aab9c8ed7ce313e9c5822412ee5e575471f32232b34724e15b2072771b2c3 and in this case there's no segfault, so the issue is with PHPUnit (see https://travis-ci.com/github/avalanche123/Imagine/builds/198035883)

ausi commented 4 years ago

Maybe we should fix the issue without having it captured by the CI for now?

mlocati commented 4 years ago

I guess it's the only solution... do you mind submitting a new pull request with only the fix?

ausi commented 4 years ago

Done: #750