search

php-imagine / Imagine

PHP Object Oriented image manipulation library
https://imagine.readthedocs.io
Other
4.42k stars 530 forks source link

Fix PHP 8.1 deprecations #768

Closed ausi closed 2 years ago

ausi commented 3 years ago

Fixes the PHP 8.1 deprecations of:

  1. https://wiki.php.net/rfc/internal_method_return_types
  2. https://wiki.php.net/rfc/deprecations_php_8_1#num_points_parameter_of_image_open_filled_polygon

We should probably wait with merging this until an RC version of PHP 8.1 was released.

ausi commented 2 years ago

PHP version 8.1.0-RC1 was released a month ago so I think this pull request is ready to merge.

HVSoftware commented 2 years ago

@ausi I see this fix is merged into the develop branch. Only this fix is not applies into the master branch. For this reason I cannot update to PHP 8.1 when using the master branch. Using the develop branch is not an option within my company. Can this fix also be applied to the master branch?

ausi commented 2 years ago

I think you have to wait until the next release. As far as I know the following issues have to be fixed before the version 1.3.0 can be released: https://github.com/php-imagine/Imagine/milestone/1

mlocati commented 2 years ago

Yep, we have a few issues that still need to be fixed. I've spent an insane amount of time trying to fix them, but no luck.

I'll try to find again some spare time to work on them (of course, any help is welcome)

HVSoftware commented 2 years ago

Clear. I will take a look at one of those issues. I'm not saying I can fix them. Only it would be nice if it can.