search

php-imagine / Imagine

PHP Object Oriented image manipulation library
https://imagine.readthedocs.io
Other
4.42k stars 530 forks source link

Add missing PHPDoc types #814

Closed ruudk closed 2 years ago

ruudk commented 2 years ago

Fixes the following deprecations reported by Symfony:

Method "Countable::count()" might add "int" as a native return type declaration in the future. Do the same in implementation "Imagine\Image\Metadata\MetadataBag" now to avoid errors or add an explicit @return annotation to suppress this message.
Method "IteratorAggregate::getIterator()" might add "\Traversable" as a native return type declaration in the future. Do the same in implementation "Imagine\Image\Metadata\MetadataBag" now to avoid errors or add an explicit @return annotation to suppress this message.
Method "ArrayAccess::offsetExists()" might add "bool" as a native return type declaration in the future. Do the same in implementation "Imagine\Image\Metadata\MetadataBag" now to avoid errors or add an explicit @return annotation to suppress this message.
Method "ArrayAccess::offsetSet()" might add "void" as a native return type declaration in the future. Do the same in implementation "Imagine\Image\Metadata\MetadataBag" now to avoid errors or add an explicit @return annotation to suppress this message.
Method "ArrayAccess::offsetUnset()" might add "void" as a native return type declaration in the future. Do the same in implementation "Imagine\Image\Metadata\MetadataBag" now to avoid errors or add an explicit @return annotation to suppress this message.
Method "ArrayAccess::offsetGet()" might add "mixed" as a native return type declaration in the future. Do the same in implementation "Imagine\Image\Metadata\MetadataBag" now to avoid errors or add an explicit @return annotation to suppress this message.

References:

ruudk commented 2 years ago

@mlocati can you approve the workflow?

mlocati commented 2 years ago

Sure! Sorry for being so silent these days: I'm having a little break

ruudk commented 2 years ago

@mlocati Thanks, the tests are failing unrelated to my change. It's ready for review. Whenever you have time, take care 💙

ausi commented 2 years ago

Sorry for being so silent these days

Please don’t be sorry ☺️
Thank you for all your tremendous work you put into this project! ❤️

SavageTiger commented 2 years ago

He @mlocati,

I am waiting on this PR so I can upgrade my Symfony installation, is there a way this could be merged soon?

Thanks!

ruudk commented 2 years ago

@mlocati Thanks for the merge, would be great to have this tagged too 🙏

mlocati commented 2 years ago

would be great to have this tagged too

Already done: see version 1.3.0