search

php-imagine / Imagine

PHP Object Oriented image manipulation library
https://imagine.readthedocs.io
Other
4.42k stars 530 forks source link

Restore broken tests #820

Closed PowerKiKi closed 2 years ago

PowerKiKi commented 2 years ago

PHP 5.5+ to restore broken tests

This restore broken tests by raising the minimum version to PHP 5.5, and testing on Windows with more recent PHP versions.

Hopefully that is an acceptable compromise since PHP 5.3 and 5.4 are now over 10 years old.

Fixes #780 Fixes #781 Fixes #783 Fixes #784 Fixes #785 Fixes #786 Fixes #788

mbabker commented 2 years ago

Hopefully that is an acceptable compromise since PHP 5.3 and 5.4 are now over 10 years old.

Doubtful, https://github.com/php-imagine/Imagine/issues/527 for context on why PHP 5.3 is still supported.

mlocati commented 2 years ago

PHP 5.5+ to restore broken tests

The tests fail not because of old PHP versions, but because of old underlying ImageMagick versions (please remark: imagick is the PHP extension, ImageMagick is a system library).

PowerKiKi commented 2 years ago

Thank you for merging this.

Of course, the language itself is not the problem, but it's all related. Supporting decade old software require a significant amount of effort, and it will only get worse as time pass.

I think you made the right choice by slightly reducing the maintenance scope for this project :tada: